Chad has uploaded a new change for review.
https://gerrit.wikimedia.org/r/273004
Change subject: Invalidate InitialiseSettings cache anytime config changes
......................................................................
Invalidate InitialiseSettings cache anytime config changes
Values are used in InitialiseSettings that are defined elsewhere.
This can lead to confusion when InitialiseSettings isn't touched
during a config change and you wonder why you're stuck with old
config.
Instead, check the mtime for the whole config directory, and cache
InitialiseSettings.php based on *that* mtime
Change-Id: I570cba970f90b970d2de5b3c2cd027e670f80458
---
M wmf-config/CommonSettings.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config
refs/changes/04/273004/1
diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index a843034..7f8453c 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -146,7 +146,7 @@
}
$globals = false;
-if ( @filemtime( $filename ) >= filemtime(
"$wmfConfigDir/InitialiseSettings.php" ) ) {
+if ( @filemtime( $filename ) >= filemtime( "$wmfConfigDir/." ) ) {
$cacheRecord = @file_get_contents( $filename );
if ( $cacheRecord !== false ) {
$globals = unserialize( $cacheRecord );
--
To view, visit https://gerrit.wikimedia.org/r/273004
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I570cba970f90b970d2de5b3c2cd027e670f80458
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
