Florianschmidtwelzow has uploaded a new change for review.
https://gerrit.wikimedia.org/r/273021
Change subject: Hygiene: Fix documentation of ResourceLoaderGetConfigVars hook
handler
......................................................................
Hygiene: Fix documentation of ResourceLoaderGetConfigVars hook handler
and hopefully make it a bit more understandable by splitting a long sentence
into understandable pieces of information.
Change-Id: Ia17aff0655a8c65426d838ea0891bbdbafd309f5
---
M includes/MobileFrontend.hooks.php
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/21/273021/1
diff --git a/includes/MobileFrontend.hooks.php
b/includes/MobileFrontend.hooks.php
index 5240b33..3cea790 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -378,9 +378,12 @@
/**
* ResourceLoaderGetConfigVars hook handler
- * This should be used for variables which vary with the html
- * and for variables that should work cross skin including anonymous
users
- * this includes use of MobileContext::isBetaGroupMember in this
function
+ * This should be used for variables which:
+ * - vary with the html
+ * - variables that should work cross skin including anonymous users
+ * - used for both, stable and beta mode (don't use
+ * MobileContext::isBetaGroupMember in this function - T127860)
+ *
* @see
https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderGetConfigVars
*
* @param array $vars
--
To view, visit https://gerrit.wikimedia.org/r/273021
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia17aff0655a8c65426d838ea0891bbdbafd309f5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
