jenkins-bot has submitted this change and it was merged.

Change subject: Use an assoc array to configure $wgOresModels
......................................................................


Use an assoc array to configure $wgOresModels

Using a list-array will append instead of replacing, so use a assoc
array with values of true/false to enable or disable.

To add a new model:
 $wgOresModels['foobar'] = true;

To disable an existing one:
 $wgOresModels['barbaz'] = false;

Change-Id: Id2feaf4b794ded72e71df83d6327ec86a37cd6ae
---
M extension.json
M includes/Scoring.php
2 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  Ladsgroup: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extension.json b/extension.json
index b1e3cad..bd0bdc9 100644
--- a/extension.json
+++ b/extension.json
@@ -72,12 +72,12 @@
        "config": {
                "OresBaseUrl": "https://ores.wmflabs.org/";,
                "OresExcludeBots": true,
-               "OresModels": [
-                       "damaging",
-                       "goodfaith",
-                       "reverted",
-                       "wp10"
-               ],
+               "OresModels": {
+                       "damaging": true,
+                       "goodfaith": true,
+                       "reverted": true,
+                       "wp10": true
+               },
                "OresDamagingThresholds": {
                        "soft": 0.70,
                        "hard": 0.50
diff --git a/includes/Scoring.php b/includes/Scoring.php
index 021e5df..a7f1c81 100644
--- a/includes/Scoring.php
+++ b/includes/Scoring.php
@@ -13,7 +13,7 @@
        public function getScores( $revisions, $models = null ) {
                if ( !$models ) {
                        global $wgOresModels;
-                       $models = $wgOresModels;
+                       $models = array_keys( array_filter( $wgOresModels ) );
                }
 
                $wireData = Api::request( [

-- 
To view, visit https://gerrit.wikimedia.org/r/273025
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2feaf4b794ded72e71df83d6327ec86a37cd6ae
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to