Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/273059
Change subject: referencesKey is now a static function
......................................................................
referencesKey is now a static function
There seems to be no reason for this to be a member function
Change-Id: I414959d4cc107135ccbd0739f2fc7d62ca8d04c5
---
M Cite_body.php
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cite
refs/changes/59/273059/1
diff --git a/Cite_body.php b/Cite_body.php
index 53a8c0a..1d86ace 100644
--- a/Cite_body.php
+++ b/Cite_body.php
@@ -786,7 +786,7 @@
if ( !is_array( $val ) ) {
return wfMessage(
'cite_references_link_one',
- $this->referencesKey( $key ),
+ self::referencesKey( $key ),
$this->refKey( $key ),
$this->referenceText( $key, $val )
)->inContentLanguage()->plain();
@@ -795,7 +795,7 @@
if ( isset( $val['follow'] ) ) {
return wfMessage(
'cite_references_no_link',
- $this->referencesKey( $val['follow'] ),
+ self::referencesKey( $val['follow'] ),
$text
)->inContentLanguage()->plain();
}
@@ -803,7 +803,7 @@
if ( $val['count'] < 0 ) {
return wfMessage(
'cite_references_link_one',
- $this->referencesKey( $val['key'] ),
+ self::referencesKey( $val['key'] ),
# $this->refKey( $val['key'],
$val['count'] ),
$this->refKey( $val['key'] ),
$text
@@ -815,7 +815,7 @@
} elseif ( $val['count'] === 0 ) {
return wfMessage(
'cite_references_link_one',
- $this->referencesKey( $key . "-" .
$val['key'] ),
+ self::referencesKey( $key . "-" .
$val['key'] ),
# $this->refKey( $key, $val['count'] ),
$this->refKey( $key, $val['key'] . "-"
. $val['count'] ),
$text
@@ -836,7 +836,7 @@
$list = $this->listToText( $links );
return wfMessage( 'cite_references_link_many',
- $this->referencesKey( $key . "-" .
$val['key'] ),
+ self::referencesKey( $key . "-" .
$val['key'] ),
$list,
$text
)->inContentLanguage()->plain();
@@ -962,7 +962,7 @@
* @param int $num The number of the key
* @return string A key for use in wikitext
*/
- function referencesKey( $key, $num = null ) {
+ public static function referencesKey( $key, $num = null ) {
$prefix = wfMessage( 'cite_references_link_prefix'
)->inContentLanguage()->text();
$suffix = wfMessage( 'cite_references_link_suffix'
)->inContentLanguage()->text();
if ( isset( $num ) ) {
@@ -997,7 +997,7 @@
wfMessage(
'cite_reference_link',
$this->refKey( $key, $count ),
- $this->referencesKey( $key . $subkey ),
+ self::referencesKey( $key . $subkey ),
$this->getLinkLabel( $label, $group,
( ( $group ===
self::DEFAULT_GROUP ) ? '' : "$group " ) . $wgContLang->formatNum( $label ) )
)->inContentLanguage()->plain()
--
To view, visit https://gerrit.wikimedia.org/r/273059
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I414959d4cc107135ccbd0739f2fc7d62ca8d04c5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
