ArielGlenn has submitted this change and it was merged. Change subject: remove old audit_files.py, no longer needed, remove unused Rule class remove unused timeout from local audit methods remove some dead attrs and args, clean up handling of ignore dicts ......................................................................
remove old audit_files.py, no longer needed, remove unused Rule class remove unused timeout from local audit methods remove some dead attrs and args, clean up handling of ignore dicts there are five possible ignore dict sources: the global_ignores file the perhost_ignores file the rulestore db (after conversion to ignores) a file exported from the rulestore db (after conversion to ignores) per-user config files placed in the home directory it is now clear which of these are used in which cases by which audit classes, as well as by the cli inspector; handling for all of these is now identical, resulting in removal of some cruft code Change-Id: Ia45cf505b5f7ef5a41ed6fd884d82933d9066187 --- D dataretention/audit_files.py M dataretention/data_auditor.py M dataretention/retention/cli.py M dataretention/retention/config.yaml M dataretention/retention/global_ignored.yaml M dataretention/retention/ignores.py M dataretention/retention/localexaminer.py M dataretention/retention/localfileaudit.py M dataretention/retention/localhomeaudit.py M dataretention/retention/locallogaudit.py M dataretention/retention/localusercfgrabber.py M dataretention/retention/remoteexaminer.py M dataretention/retention/remotefileauditor.py M dataretention/retention/remotehomeauditor.py M dataretention/retention/remotelogauditor.py M dataretention/retention/remoteusercfgrabber.py M dataretention/retention/retentionaudit.py M dataretention/retention/rule.py M dataretention/retention/ruleutils.py M dataretention/rulestore.py 20 files changed, 363 insertions(+), 5,713 deletions(-) Approvals: ArielGlenn: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/233471 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia45cf505b5f7ef5a41ed6fd884d82933d9066187 Gerrit-PatchSet: 2 Gerrit-Project: operations/software Gerrit-Branch: master Gerrit-Owner: ArielGlenn <[email protected]> Gerrit-Reviewer: ArielGlenn <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
