jenkins-bot has submitted this change and it was merged.
Change subject: GotoLine: Don't throw an exception if the user cancels the
prompt
......................................................................
GotoLine: Don't throw an exception if the user cancels the prompt
Change-Id: I540ba492cf3acda01ad61800561cda0276f36c76
---
M modules/jquery.codeEditor.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/jquery.codeEditor.js b/modules/jquery.codeEditor.js
index b3a5457..b6914b3 100644
--- a/modules/jquery.codeEditor.js
+++ b/modules/jquery.codeEditor.js
@@ -120,7 +120,7 @@
},
aceGotoLineColumn: function () {
var lineinput = prompt( 'Enter line number:',
'line:column' ),
- matches = lineinput.split( ':' ),
+ matches = lineinput ? lineinput.split(
':' ) : [],
line = 0,
column = 0;
--
To view, visit https://gerrit.wikimedia.org/r/273658
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I540ba492cf3acda01ad61800561cda0276f36c76
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
