Yaron Koren has submitted this change and it was merged.
Change subject: Removed check for non-blank username in get_db_data
......................................................................
Removed check for non-blank username in get_db_data
Change-Id: I8bf66592b5cde590a2ddf763025158b1b9475595
---
M ED_Utils.php
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Yaron Koren: Looks good to me, approved
jenkins-bot: Verified
diff --git a/ED_Utils.php b/ED_Utils.php
index 30b99b4..0117a66 100644
--- a/ED_Utils.php
+++ b/ED_Utils.php
@@ -193,10 +193,9 @@
return wfMessage(
"externaldata-db-incomplete-information" )->text();
}
} else {
- // We don't check the password because it could
- // legitimately be blank or null.
- if ( $db_server == '' || $db_name == '' ||
- $db_username == '' ) {
+ // We don't check the username or password because they
+ // could legitimately be blank or null.
+ if ( $db_server == '' || $db_name == '' ) {
return wfMessage(
"externaldata-db-incomplete-information" )->text();
}
}
--
To view, visit https://gerrit.wikimedia.org/r/273956
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8bf66592b5cde590a2ddf763025158b1b9475595
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ExternalData
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <[email protected]>
Gerrit-Reviewer: Yaron Koren <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
