jenkins-bot has submitted this change and it was merged.
Change subject: Bidi-isolate notification bodies
......................................................................
Bidi-isolate notification bodies
Use dir=auto instead of wrapping in <bdi>.
They have the same effect, except that the latter produces
strange-looking truncation behavior with LTR body text in an RTL
interface because text-overflow: ellipsis; is set on the <div>,
not on the <bdi> node.
Bug: T127407
Change-Id: Id58a70f5b88a10c827e61d9e16aae1a81938709a
---
M modules/ooui/mw.echo.ui.NotificationItemWidget.js
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Mooeypoo: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ooui/mw.echo.ui.NotificationItemWidget.js
b/modules/ooui/mw.echo.ui.NotificationItemWidget.js
index 0b4be95..114be58 100644
--- a/modules/ooui/mw.echo.ui.NotificationItemWidget.js
+++ b/modules/ooui/mw.echo.ui.NotificationItemWidget.js
@@ -58,6 +58,9 @@
$( '<div>' )
.addClass(
'mw-echo-ui-notificationItemWidget-content-message-body' )
.append( this.model.getContentBody() )
+ // dir=auto has a similar effect to
wrapping the content in <bdi>, but
+ // makes text-overflow: ellipsis;
behave less strangely
+ .attr( 'dir', 'auto' )
);
}
--
To view, visit https://gerrit.wikimedia.org/r/272934
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id58a70f5b88a10c827e61d9e16aae1a81938709a
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
