Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/273988
Change subject: Add wgVersion to SaveTiming and NavigationTiming events
......................................................................
Add wgVersion to SaveTiming and NavigationTiming events
This should allow us to better isolate performance regressions.
Bug: T112557
Change-Id: I8d85c9c7f9c2a964c72de9ea32366936d33958f7
---
M extension.json
M modules/ext.navigationTiming.js
2 files changed, 5 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NavigationTiming
refs/changes/88/273988/1
diff --git a/extension.json b/extension.json
index 92c196b..fdce637 100644
--- a/extension.json
+++ b/extension.json
@@ -48,8 +48,8 @@
]
},
"EventLoggingSchemas": {
- "NavigationTiming": 15033442,
- "SaveTiming": 12236257
+ "NavigationTiming": 15396488,
+ "SaveTiming": 15396492
},
"config": {
"NavigationTimingSamplingFactor": false
diff --git a/modules/ext.navigationTiming.js b/modules/ext.navigationTiming.js
index bf1f4f8..778de56 100644
--- a/modules/ext.navigationTiming.js
+++ b/modules/ext.navigationTiming.js
@@ -116,7 +116,8 @@
var event = {
isHttp2: /H2/.test( $.cookie( 'CP' ) ),
isHiDPI: getDevicePixelRatio() > 1,
- isAnon: mw.config.get( 'wgUserId' ) === null
+ isAnon: mw.config.get( 'wgUserId' ) === null,
+ mediaWikiVersion: mw.config.get( 'wgVersion' )
},
page = {
pageId: mw.config.get( 'wgArticleId' ),
@@ -174,6 +175,7 @@
navTiming = getNavTiming();
if ( navTiming.responseStart ) {
mw.eventLog.logEvent( 'SaveTiming', {
+ mediaWikiVersion: mw.config.get( 'wgVersion' ),
saveTiming: navTiming.responseStart
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/273988
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d85c9c7f9c2a964c72de9ea32366936d33958f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NavigationTiming
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
