Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/273990
Change subject: Report save timing by MediaWiki version
......................................................................
Report save timing by MediaWiki version
Add a 'mw.performance.save_by_version' key namespace which includes a
normalized $wgVersion as part of the key name. This should allow us to compare
performance across branches and catch performance regressions.
Bug: T112557
Change-Id: Ia07b03f12b1bd146a6935d27d08b6360fa351e62
---
M modules/webperf/files/navtiming.py
1 file changed, 6 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/90/273990/1
diff --git a/modules/webperf/files/navtiming.py
b/modules/webperf/files/navtiming.py
index e01fd2c..6797d3a 100755
--- a/modules/webperf/files/navtiming.py
+++ b/modules/webperf/files/navtiming.py
@@ -137,15 +137,13 @@
@handles('SaveTiming')
def handle_save_timing(meta):
event = meta['event']
- duration = event.get('saveTiming')
- if duration is None:
- duration = event.get('duration')
- if duration and is_sane(duration):
+ duration = event.get('duration')
+ version = event.get('mediaWikiVersion')
+ if is_sane(duration):
dispatch_stat('mw.performance.save', duration)
-
- # Ori, for T126700 -- 17-Feb-2016
- if meta.get('wiki', '') == 'mediawikiwiki':
- dispatch_stat('tmp.performance.save', duration)
+ if version:
+ dispatch_stat('mw.performance.save_by_version',
+ version.replace('.', '_'), duration)
@handles('NavigationTiming')
--
To view, visit https://gerrit.wikimedia.org/r/273990
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia07b03f12b1bd146a6935d27d08b6360fa351e62
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
