Ricordisamoa has uploaded a new change for review.
https://gerrit.wikimedia.org/r/273996
Change subject: build: Enable jscs jsDoc rule 'checkTypes' and make pass
......................................................................
build: Enable jscs jsDoc rule 'checkTypes' and make pass
Change-Id: I0da7d6b59c33b25c07874e8ff9f149637955657c
---
M .jscsrc
M src/Toolbar.js
M src/core.js
M src/widgets/SelectFileWidget.js
4 files changed, 7 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/96/273996/1
diff --git a/.jscsrc b/.jscsrc
index 4c8b23d..b02b473 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -11,6 +11,7 @@
"requireParamTypes": true,
"checkReturnTypes": true,
"requireReturnTypes": true,
+ "checkTypes": "strictNativeCase",
"checkRedundantAccess": true,
"requireNewlineAfterDescription": true
}
diff --git a/src/Toolbar.js b/src/Toolbar.js
index 73c9e45..39e4f41 100644
--- a/src/Toolbar.js
+++ b/src/Toolbar.js
@@ -342,7 +342,7 @@
* every time the state of the application using the toolbar changes, and an
update to the state of
* tools is required.
*
- * @param {Mixed...} data Application-defined parameters
+ * @param {...Mixed} data Application-defined parameters
*/
/* Methods */
diff --git a/src/core.js b/src/core.js
index a7fee1d..59c84f3 100644
--- a/src/core.js
+++ b/src/core.js
@@ -42,14 +42,14 @@
};
/**
- * @property {Number}
+ * @property {number}
*/
OO.ui.elementId = 0;
/**
* Generate a unique ID for element
*
- * @return {String} [id]
+ * @return {string} [id]
*/
OO.ui.generateElementId = function () {
OO.ui.elementId += 1;
@@ -342,7 +342,7 @@
* they support unnamed, ordered message parameters.
*
* @param {string} key Message key
- * @param {Mixed...} [params] Message parameters
+ * @param {...Mixed} [params] Message parameters
* @return {string} Translated message with parameters substituted
*/
OO.ui.msg = function ( key ) {
@@ -368,7 +368,7 @@
* Use this when you are statically specifying a message and the message may
not yet be present.
*
* @param {string} key Message key
- * @param {Mixed...} [params] Message parameters
+ * @param {...Mixed} [params] Message parameters
* @return {Function} Function that returns the resolved message when executed
*/
OO.ui.deferMsg = function () {
diff --git a/src/widgets/SelectFileWidget.js b/src/widgets/SelectFileWidget.js
index a34c0ef..062596f 100644
--- a/src/widgets/SelectFileWidget.js
+++ b/src/widgets/SelectFileWidget.js
@@ -25,7 +25,7 @@
* @cfg {string} [notsupported] Text to display when file support is missing
in the browser.
* @cfg {boolean} [droppable=true] Whether to accept files by drag and drop.
* @cfg {boolean} [showDropTarget=false] Whether to show a drop target.
Requires droppable to be true.
- * @cfg {Number} [thumbnailSizeLimit=20] File size limit in MiB above which to
not try and show a
+ * @cfg {number} [thumbnailSizeLimit=20] File size limit in MiB above which to
not try and show a
* preview (for performance)
*/
OO.ui.SelectFileWidget = function OoUiSelectFileWidget( config ) {
--
To view, visit https://gerrit.wikimedia.org/r/273996
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0da7d6b59c33b25c07874e8ff9f149637955657c
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
