[MediaWiki-commits] [Gerrit] Add access modifiers to MagicWordArray.php - change (mediawiki/core)

[Addshore (Code Review)]

Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/274074

Change subject: Add access modifiers to MagicWordArray.php
......................................................................

Add access modifiers to MagicWordArray.php

Change-Id: Ib5fe0fd22a6f24142f1e87338298c1bdef45cc4a
---
M includes/MagicWordArray.php
1 file changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/74/274074/1

diff --git a/includes/MagicWordArray.php b/includes/MagicWordArray.php
index ee5de6b..6a9ead5 100644
--- a/includes/MagicWordArray.php
+++ b/includes/MagicWordArray.php
@@ -42,7 +42,7 @@
        /**
         * @param array $names
         */
-       function __construct( $names = [] ) {
+       public function __construct( $names = [] ) {
                $this->names = $names;
        }
 
@@ -70,7 +70,7 @@
         * Get a 2-d hashtable for this array
         * @return array
         */
-       function getHash() {
+       public function getHash() {
                if ( is_null( $this->hash ) ) {
                        global $wgContLang;
                        $this->hash = [ 0 => [], 1 => [] ];
@@ -92,7 +92,7 @@
         * Get the base regex
         * @return array
         */
-       function getBaseRegex() {
+       public function getBaseRegex() {
                if ( is_null( $this->baseRegex ) ) {
                        $this->baseRegex = [ 0 => '', 1 => '' ];
                        foreach ( $this->names as $name ) {
@@ -117,7 +117,7 @@
         * Get an unanchored regex that does not match parameters
         * @return array
         */
-       function getRegex() {
+       public function getRegex() {
                if ( is_null( $this->regex ) ) {
                        $base = $this->getBaseRegex();
                        $this->regex = [ '', '' ];
@@ -136,7 +136,7 @@
         *
         * @return string
         */
-       function getVariableRegex() {
+       public function getVariableRegex() {
                return str_replace( "\\$1", "(.*?)", $this->getRegex() );
        }
 
@@ -145,7 +145,7 @@
         *
         * @return array
         */
-       function getRegexStart() {
+       public function getRegexStart() {
                $base = $this->getBaseRegex();
                $newRegex = [ '', '' ];
                if ( $base[0] !== '' ) {
@@ -162,7 +162,7 @@
         *
         * @return array
         */
-       function getVariableStartToEndRegex() {
+       public function getVariableStartToEndRegex() {
                $base = $this->getBaseRegex();
                $newRegex = [ '', '' ];
                if ( $base[0] !== '' ) {
@@ -192,7 +192,7 @@
         * @throws MWException
         * @return array
         */
-       function parseMatch( $m ) {
+       public function parseMatch( $m ) {
                reset( $m );
                while ( list( $key, $value ) = each( $m ) ) {
                        if ( $key === 0 || $value === '' ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/274074
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5fe0fd22a6f24142f1e87338298c1bdef45cc4a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits