jenkins-bot has submitted this change and it was merged.
Change subject: Check VE is available before running unit tests
......................................................................
Check VE is available before running unit tests
Bug: T127763
Change-Id: I95f3e7419c4417d4dc3fbcb2aed54f2df8a49b70
---
M Citoid.hooks.php
1 file changed, 14 insertions(+), 9 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Citoid.hooks.php b/Citoid.hooks.php
index b866941..51fa2ee 100644
--- a/Citoid.hooks.php
+++ b/Citoid.hooks.php
@@ -28,16 +28,21 @@
array &$testModules,
ResourceLoader &$resourceLoader
) {
- $testModules['qunit']['ext.citoid.tests'] = array(
- 'scripts' => array(
- 'modules/tests/index.test.js'
+ if (
+ isset( $resourceModules[ 'ext.visualEditor.mediawiki' ]
) ||
+ $resourceLoader->isModuleRegistered(
'ext.visualEditor.mediawiki' )
+ ) {
+ $testModules['qunit']['ext.citoid.tests'] = array(
+ 'scripts' => array(
+ 'modules/tests/index.test.js'
+ ),
+ 'dependencies' => array(
+ 'ext.citoid.visualEditor',
),
- 'dependencies' => array(
- 'ext.citoid.visualEditor',
- ),
- 'localBasePath' => __DIR__,
- 'remoteExtPath' => 'Citoid',
- );
+ 'localBasePath' => __DIR__,
+ 'remoteExtPath' => 'Citoid',
+ );
+ }
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/274091
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95f3e7419c4417d4dc3fbcb2aed54f2df8a49b70
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Citoid
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
