Pgehres has submitted this change and it was merged. Change subject: (bug 43810) Deleting CN Campaign causes PHP Warn ......................................................................
(bug 43810) Deleting CN Campaign causes PHP Warn PHP was throwing a warning where we attempted to diff a settings object that was non existant because the campaign had probably been deleted before hand. I've choosen to not attempt the diff of objects that return a null settings object. This seems like the best path because I like the idea of not returning an array from getCampaignSettings() when something doesn't exist. I've looked at all the other use cases and I think this is the only one affected. There may be point cases where we have timing bugs but I'm going to defer on addressing those until we refactor CN into proper classes. Change-Id: I81432368f895d5a0c3ba968086ae17485aaf8022 --- M CentralNotice.db.php M special/SpecialCentralNotice.php 2 files changed, 15 insertions(+), 4 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved Dereckson: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/43355 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81432368f895d5a0c3ba968086ae17485aaf8022 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Mwalker <mwal...@wikimedia.org> Gerrit-Reviewer: Dereckson <dereck...@espace-win.org> Gerrit-Reviewer: Mwalker <mwal...@wikimedia.org> Gerrit-Reviewer: Pgehres <pgeh...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
