Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/274668

Change subject: MT Card: Correct the menu when MT is disabled by default
......................................................................

MT Card: Correct the menu when MT is disabled by default

Refer screenshots in T117035

Bug: T117035
Change-Id: I07badf4378b6f743cc7e924ccb6df55b481e24e0
---
M i18n/en.json
M modules/tools/ext.cx.tools.mt.js
2 files changed, 11 insertions(+), 14 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/68/274668/1

diff --git a/i18n/en.json b/i18n/en.json
index f0a148a..c758459 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -71,7 +71,7 @@
        "cx-tools-link-title": "Link",
        "cx-tools-link-add": "Add link",
        "cx-tools-link-remove": "Remove link",
-       "cx-tools-mt-title": "Machine translation",
+       "cx-tools-mt-title": "Automatic translation",
        "cx-tools-mt-use-source": "Use source text",
        "cx-tools-mt-clear-translation": "Clear paragraph",
        "cx-tools-mt-restore": "Restore",
diff --git a/modules/tools/ext.cx.tools.mt.js b/modules/tools/ext.cx.tools.mt.js
index 8f7a16c..0037c76 100644
--- a/modules/tools/ext.cx.tools.mt.js
+++ b/modules/tools/ext.cx.tools.mt.js
@@ -433,28 +433,25 @@
        };
 
        MTControlCard.prototype.buildProvidersMenu = function () {
-               var provider;
+               var provider, items;
 
                this.$providersMenu = $( '<ul>' )
                        .addClass( 'card__providers-menu' )
                        .hide();
 
+               items = MTControlCard.providers || [];
+               if ( items.indexOf( sourceMT ) < 0 ) {
+                       items.push( sourceMT );
+               }
+               if ( items.indexOf( disableMT ) < 0 ) {
+                       items.push( disableMT );
+               }
                // Add available machine translation engines to the menu
-               for ( provider in MTControlCard.providers ) {
+               for ( provider in items ) {
                        this.$providersMenu.append(
-                               this.getProviderItem(
-                                       MTControlCard.providers[ provider ],
-                                       mw.cx.sourceLanguage,
-                                       mw.cx.targetLanguage
-                               )
+                               this.getProviderItem( items[ provider ] )
                        );
                }
-
-               // Add an item to disable machine translation for the language
-               this.$providersMenu.append(
-                       this.getProviderItem( sourceMT ),
-                       this.getProviderItem( disableMT )
-               );
 
                this.$providerSelectorTrigger.after( this.$providersMenu );
        };

-- 
To view, visit https://gerrit.wikimedia.org/r/274668
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I07badf4378b6f743cc7e924ccb6df55b481e24e0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to