Ladsgroup has uploaded a new change for review. https://gerrit.wikimedia.org/r/274912
Change subject: Use ensure_package instead of require_package in ORES ...................................................................... Use ensure_package instead of require_package in ORES Using require_package checks the package is installed and *declares* it [1] but if we use ensure_package like wikilabels [2] we won't run into problems like what's happening right now (see the phab cards) [1]: https://phabricator.wikimedia.org/diffusion/OPUP/browse/production/modules/wmflib/lib/puppet/parser/functions/require_package.rb [2]: https://github.com/wikimedia/operations-puppet/blob/production/modules/wikilabels/manifests/web.pp#L14 Bug: T127975 Bug: T124621 Change-Id: I89910c848083f22a7bd0d81c59103104c43f7fee --- M modules/ores/manifests/web.pp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/12/274912/1 diff --git a/modules/ores/manifests/web.pp b/modules/ores/manifests/web.pp index 9e18e32..dff563b 100644 --- a/modules/ores/manifests/web.pp +++ b/modules/ores/manifests/web.pp @@ -6,7 +6,7 @@ require ores::base # ORES is a python3 application \o/ - require_package('uwsgi-plugin-python3') + ensure_package('uwsgi-plugin-python3') uwsgi::app { 'ores-web': settings => { -- To view, visit https://gerrit.wikimedia.org/r/274912 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I89910c848083f22a7bd0d81c59103104c43f7fee Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ladsgroup <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
