Xqt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/274977
Change subject: Remove special_page_limit from config2.py
......................................................................
Remove special_page_limit from config2.py
special_page_limit was introduced in compat for retrieving pages from
mw special list via screen scraping. The use of this parameter in compat
is a mess but in core it is not used. api may read all items except a total
parameter for a generator or treat counter restricts it.
The only use of that parameter is inside site.watched_page but it doesn't
make any sense to have that default value.
Change-Id: Idd0afa55cec93b92abbd5f0a9d2d0b9317a9a42a
---
M pywikibot/config2.py
M pywikibot/site.py
2 files changed, 0 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/77/274977/1
diff --git a/pywikibot/config2.py b/pywikibot/config2.py
index 7fc9d7a..5109452 100644
--- a/pywikibot/config2.py
+++ b/pywikibot/config2.py
@@ -612,11 +612,6 @@
# at least 1 second.
maxlag = 5
-# Maximum of pages which can be retrieved by special pages. Increase this if
-# you heavily use redirect.py with action "double", and especially if you're
-# running solve_disambiguation.py with the -primary argument.
-special_page_limit = 500
-
# Maximum number of times to retry an API request before quitting.
max_retries = 25
# Minimum time to wait before resubmitting a failed API request.
diff --git a/pywikibot/site.py b/pywikibot/site.py
index 4304a67..c6f82c0 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -6679,8 +6679,6 @@
@rtype: list of pywikibot.Page objects
"""
self.login(sysop=sysop)
- if not total:
- total = pywikibot.config.special_page_limit
expiry = None if force else pywikibot.config.API_config_expiry
gen = api.PageGenerator(site=self, generator='watchlistraw',
expiry=expiry, gwrlimit=total)
--
To view, visit https://gerrit.wikimedia.org/r/274977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd0afa55cec93b92abbd5f0a9d2d0b9317a9a42a
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
