Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/275033
Change subject: Fix some JobQueue IDEA errors
......................................................................
Fix some JobQueue IDEA errors
Change-Id: I624f65ee1ca97c1acae9b54ca36d910eb4e42a70
---
M includes/jobqueue/JobQueueDB.php
M includes/jobqueue/JobQueueFederated.php
2 files changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/33/275033/1
diff --git a/includes/jobqueue/JobQueueDB.php b/includes/jobqueue/JobQueueDB.php
index aaf9fb0..201f556 100644
--- a/includes/jobqueue/JobQueueDB.php
+++ b/includes/jobqueue/JobQueueDB.php
@@ -476,8 +476,6 @@
} catch ( DBError $e ) {
$this->throwDBException( $e );
}
-
- return true;
}
/**
diff --git a/includes/jobqueue/JobQueueFederated.php
b/includes/jobqueue/JobQueueFederated.php
index c127239..bd832db 100644
--- a/includes/jobqueue/JobQueueFederated.php
+++ b/includes/jobqueue/JobQueueFederated.php
@@ -49,7 +49,7 @@
class JobQueueFederated extends JobQueue {
/** @var HashRing */
protected $partitionRing;
- /** @var array (partition name => JobQueue) reverse sorted by weight */
+ /** @var JobQueue[] (partition name => JobQueue) reverse sorted by
weight */
protected $partitionQueues = [];
/** @var int Maximum number of partitions to try */
@@ -311,7 +311,7 @@
throw new MWException( "The given job has no defined
partition name." );
}
- return
$this->partitionQueues[$job->metadata['QueuePartition']]->ack( $job );
+ $this->partitionQueues[$job->metadata['QueuePartition']]->ack(
$job );
}
protected function doIsRootJobOldDuplicate( Job $job ) {
--
To view, visit https://gerrit.wikimedia.org/r/275033
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I624f65ee1ca97c1acae9b54ca36d910eb4e42a70
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
