jenkins-bot has submitted this change and it was merged.
Change subject: TextInputWidget: Update comment about Blink height
miscalculation
......................................................................
TextInputWidget: Update comment about Blink height miscalculation
The original issue from f1dd60e18 (T73310) seems to no longer be present,
but this is still necessary to prevent silly scrollbars when zoomed in.
In my testing, measurementError equals 0.8571420000000103 when zoom level
is 175%, resulting in a scrollbar without this hack. (It takes different
values between -1 and 1 on different zoom levels, most however do not
result in spurious scrollbars.)
Change-Id: I12404c0e9f075d9a331e5840c7ebcf4f38fafa2c
---
M src/widgets/TextInputWidget.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/widgets/TextInputWidget.js b/src/widgets/TextInputWidget.js
index 636f7ea..0c4a4a8 100644
--- a/src/widgets/TextInputWidget.js
+++ b/src/widgets/TextInputWidget.js
@@ -428,8 +428,8 @@
.val( '' );
maxInnerHeight = this.$clone.innerHeight();
- // Difference between reported innerHeight and
scrollHeight with no scrollbars present
- // Equals 1 on Blink-based browsers and 0 everywhere
else
+ // Difference between reported innerHeight and
scrollHeight with no scrollbars present.
+ // This is sometimes non-zero on Blink-based browsers,
depending on zoom level.
measurementError = maxInnerHeight - this.$clone[ 0
].scrollHeight;
idealHeight = Math.min( maxInnerHeight, scrollHeight +
measurementError );
--
To view, visit https://gerrit.wikimedia.org/r/275676
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12404c0e9f075d9a331e5840c7ebcf4f38fafa2c
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
