jenkins-bot has submitted this change and it was merged. Change subject: Include database version in upgrade crash reports ......................................................................
Include database version in upgrade crash reports Improve the ability to diagnose crashes during database upgrades by including the version upgraded from in the report. https://rink.hockeyapp.net/manage/apps/226649/app_versions/15/crashes/6006003581 Change-Id: I0915ef7cd2d1133ff7855f977a5f3421ee70a52c --- M app/src/main/java/org/wikipedia/database/Database.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Dbrant: Looks good to me, approved jenkins-bot: Verified diff --git a/app/src/main/java/org/wikipedia/database/Database.java b/app/src/main/java/org/wikipedia/database/Database.java index b3b1923..d2975dc 100644 --- a/app/src/main/java/org/wikipedia/database/Database.java +++ b/app/src/main/java/org/wikipedia/database/Database.java @@ -4,6 +4,7 @@ import android.database.sqlite.SQLiteDatabase; import android.database.sqlite.SQLiteOpenHelper; +import org.wikipedia.WikipediaApp; import org.wikipedia.history.HistoryEntry; import org.wikipedia.savedpages.SavedPage; import org.wikipedia.editing.summaries.EditSummary; @@ -40,6 +41,7 @@ @Override public void onUpgrade(SQLiteDatabase sqLiteDatabase, int from, int to) { L.i("Upgrading from=" + from + " to=" + to); + WikipediaApp.getInstance().putCrashReportProperty("fromDatabaseVersion", String.valueOf(from)); for (DatabaseTable<?> table : databaseTables) { table.upgradeSchema(sqLiteDatabase, from, to); } -- To view, visit https://gerrit.wikimedia.org/r/275884 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0915ef7cd2d1133ff7855f977a5f3421ee70a52c Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Niedzielski <[email protected]> Gerrit-Reviewer: BearND <[email protected]> Gerrit-Reviewer: Brion VIBBER <[email protected]> Gerrit-Reviewer: Dbrant <[email protected]> Gerrit-Reviewer: Mholloway <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
