Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/276060
Change subject: Skin::newFromKey() was removed
......................................................................
Skin::newFromKey() was removed
Deprecated since 1.24. No uses in core or Gerrit extensions remaining.
Change-Id: If5d18ec56a066ea3ab28503b1bf5a84a8588ba5a
---
M RELEASE-NOTES-1.27
M includes/skins/Skin.php
2 files changed, 1 insertion(+), 17 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/60/276060/1
diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27
index c79eb10..363a6f3 100644
--- a/RELEASE-NOTES-1.27
+++ b/RELEASE-NOTES-1.27
@@ -242,6 +242,7 @@
* OutputPage::setAllowedModules() was removed (deprecated since 1.24).
* Skin::commonPrintStylesheet() was removed (deprecated since 1.22).
* Skin::getCommonStylePath() was removed (deprecated since 1.24).
+* Skin::newFromKey() was removed (deprecated since 1.24).
* UserrightsPage::makeGroupNameListForLog() was removed (deprecated since
1.21).
=== Languages updated in 1.27 ===
diff --git a/includes/skins/Skin.php b/includes/skins/Skin.php
index 3adcc7e..5d7a959 100644
--- a/includes/skins/Skin.php
+++ b/includes/skins/Skin.php
@@ -141,23 +141,6 @@
}
/**
- * Factory method for loading a skin of a given type
- * @param string $key 'monobook', 'vector', etc.
- * @return Skin
- * @deprecated since 1.24; Use SkinFactory instead
- */
- static function &newFromKey( $key ) {
- wfDeprecated( __METHOD__, '1.24' );
-
- $key = Skin::normalizeKey( $key );
- $factory = SkinFactory::getDefaultInstance();
-
- // normalizeKey() guarantees that a skin with this key will
exist.
- $skin = $factory->makeSkin( $key );
- return $skin;
- }
-
- /**
* @return string Skin name
*/
public function getSkinName() {
--
To view, visit https://gerrit.wikimedia.org/r/276060
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5d18ec56a066ea3ab28503b1bf5a84a8588ba5a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <siebr...@kitano.nl>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
