jenkins-bot has submitted this change and it was merged.
Change subject: Replace the custom dropdown with a native <select> element.
......................................................................
Replace the custom dropdown with a native <select>
element.
- Styling this native <select> element as well as we can, but it may look a
little odd with old browsers.
- Solves mobile user experience issues because the device's native selector
will be triggered and is a lot easier to use.
- Solves non-JS traffic because it's a native <select> now
Though the user experience is a little worse than when JS is enabled.
(We need JS to make the custom arrow clickable)
Bug: T125571
Change-Id: Ie0f43b46007d7c3a73a566dae16fce2a31e9b8f2
---
M dev/wikipedia.org/assets/css/style.css
M dev/wikipedia.org/assets/js/pab2.js
M dev/wikipedia.org/assets/js/wm-portal.js
M dev/wikipedia.org/assets/postcss/_pab1.css
M dev/wikipedia.org/assets/postcss/_wm-portal.css
M dev/wikipedia.org/assets/rev-manifest.json
M dev/wikipedia.org/index.handlebars
D dev/wikipedia.org/templates/search-pab1.handlebars
D dev/wikipedia.org/templates/search-pab1.option.handlebars
M dev/wikipedia.org/templates/search.handlebars
D prod/wikipedia.org/assets/js/index-7ded0ace2c.js
A prod/wikipedia.org/assets/js/index-8366dee471.js
M prod/wikipedia.org/index.html
13 files changed, 352 insertions(+), 890 deletions(-)
Approvals:
JGirault: Looks good to me, approved
jenkins-bot: Verified
Objections:
Jdrewniak: There's a problem with this change, please improve
--
To view, visit https://gerrit.wikimedia.org/r/274332
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0f43b46007d7c3a73a566dae16fce2a31e9b8f2
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/portals
Gerrit-Branch: search-box
Gerrit-Owner: JGirault <jgira...@wikimedia.org>
Gerrit-Reviewer: JGirault <jgira...@wikimedia.org>
Gerrit-Reviewer: Jdrewniak <jdrewn...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
