BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/276214
Change subject: Reduce Read More thumbnail size
......................................................................
Reduce Read More thumbnail size
Previously, we had an A/B test, which had a bigger thumbnail size for
entries in the "Read more" section of a page. This A/B test has been
removed from the code base but the thumbnail size was not reduced
to its original value. This patch corrects that.
Change-Id: I875e80a400e0261dd1049545a86a09ea068a2966
---
M app/src/androidTest/java/org/wikipedia/test/SuggestionsTaskTests.java
M app/src/main/java/org/wikipedia/page/SuggestionsTask.java
M app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
M app/src/main/java/org/wikipedia/search/FullSearchArticlesTask.java
4 files changed, 7 insertions(+), 19 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/14/276214/1
diff --git
a/app/src/androidTest/java/org/wikipedia/test/SuggestionsTaskTests.java
b/app/src/androidTest/java/org/wikipedia/test/SuggestionsTaskTests.java
index 44ab7fc..ef28132 100644
--- a/app/src/androidTest/java/org/wikipedia/test/SuggestionsTaskTests.java
+++ b/app/src/androidTest/java/org/wikipedia/test/SuggestionsTaskTests.java
@@ -19,7 +19,6 @@
public class SuggestionsTaskTests extends
ActivityUnitTestCase<TestDummyActivity> {
private static final int TASK_COMPLETION_TIMEOUT = 200000;
private static final int BATCH_SIZE = 3;
- private static final int THUMB_SIZE = 100;
private static final Site SITE = new Site("en.wikipedia.org"); //
suggestions don't seem to work on testwiki
private WikipediaApp app = WikipediaApp.getInstance();
@@ -34,7 +33,7 @@
@Override
public void run() {
new SuggestionsTask(app.getAPIForSite(SITE), SITE, "test",
- BATCH_SIZE + 1, BATCH_SIZE, THUMB_SIZE, false) {
+ BATCH_SIZE + 1, BATCH_SIZE, false) {
@Override
public void onFinish(SearchResults results) {
assertNotNull(results);
@@ -83,7 +82,7 @@
private void checkFilter(int expected, List<PageTitle> originalResults) {
SuggestionsTask task = new SuggestionsTask(app.getAPIForSite(SITE),
SITE, "test",
- BATCH_SIZE + 1, BATCH_SIZE, THUMB_SIZE, false);
+ BATCH_SIZE + 1, BATCH_SIZE, false);
SearchResults searchResults = new SearchResults(originalResults, null,
null);
List<PageTitle> filteredList =
task.filterResults(searchResults).getPageTitles();
assertEquals(expected, filteredList.size());
diff --git a/app/src/main/java/org/wikipedia/page/SuggestionsTask.java
b/app/src/main/java/org/wikipedia/page/SuggestionsTask.java
index 65fa8e0..b2e40af 100644
--- a/app/src/main/java/org/wikipedia/page/SuggestionsTask.java
+++ b/app/src/main/java/org/wikipedia/page/SuggestionsTask.java
@@ -20,10 +20,9 @@
private final int maxItems;
private final boolean requireThumbnail;
- public SuggestionsTask(Api api, Site site, String title,
- int numRequestItems, int maxResultItems,
- int thumbSize, boolean requireThumbnail) {
- super(api, site, title, numRequestItems, null, true, thumbSize);
+ public SuggestionsTask(Api api, Site site, String title, int
numRequestItems,
+ int maxResultItems, boolean requireThumbnail) {
+ super(api, site, title, numRequestItems, null, true);
this.title = title;
this.maxItems = maxResultItems;
this.requireThumbnail = requireThumbnail;
diff --git
a/app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
b/app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
index 5ddca25..d60a117 100644
---
a/app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
+++
b/app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
@@ -314,8 +314,7 @@
final int numRequestItems = 5;
final long timeMillis = System.currentTimeMillis();
new SuggestionsTask(app.getAPIForSite(myTitle.getSite()),
myTitle.getSite(),
- myTitle.getPrefixedText(), numRequestItems, maxResultItems,
-
(int)(parentFragment.getActivity().getResources().getDimension(R.dimen.leadImageWidth)
/ displayDensity), false) {
+ myTitle.getPrefixedText(), numRequestItems,
maxResultItems, false) {
@Override
public void onFinish(SearchResults results) {
funnel.setLatency(System.currentTimeMillis() - timeMillis);
diff --git a/app/src/main/java/org/wikipedia/search/FullSearchArticlesTask.java
b/app/src/main/java/org/wikipedia/search/FullSearchArticlesTask.java
index eb7f778..f432ac3 100644
--- a/app/src/main/java/org/wikipedia/search/FullSearchArticlesTask.java
+++ b/app/src/main/java/org/wikipedia/search/FullSearchArticlesTask.java
@@ -25,25 +25,16 @@
private final String searchTerm;
private final int maxResults;
private final FTContinueOffset continueOffset;
- private final int thumbSize;
private final boolean getMoreLike;
public FullSearchArticlesTask(Api api, Site site, String searchTerm, int
maxResults,
SearchResults.ContinueOffset continueOffset,
boolean getMoreLike) {
- this(api, site, searchTerm, maxResults, continueOffset, getMoreLike,
- WikipediaApp.PREFERRED_THUMB_SIZE);
- }
-
- public FullSearchArticlesTask(Api api, Site site, String searchTerm, int
maxResults,
- SearchResults.ContinueOffset continueOffset,
boolean getMoreLike,
- int thumbSize) {
super(api);
this.site = site;
this.searchTerm = searchTerm;
this.maxResults = maxResults;
this.continueOffset = (FTContinueOffset) continueOffset;
- this.thumbSize = thumbSize;
this.getMoreLike = getMoreLike;
}
@@ -62,7 +53,7 @@
.param("gsrprop", "redirecttitle")
.param("gsrlimit", maxResultsString)
.param("piprop", "thumbnail") // for thumbnail URLs
- .param("pithumbsize", Integer.toString(thumbSize))
+ .param("pithumbsize",
Integer.toString(WikipediaApp.PREFERRED_THUMB_SIZE))
.param("pilimit", maxResultsString);
if (continueOffset != null) {
req.param("continue", continueOffset.cont);
--
To view, visit https://gerrit.wikimedia.org/r/276214
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I875e80a400e0261dd1049545a86a09ea068a2966
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
