Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/276216
Change subject: testsuitegenerator: Test every triple of config options for
ButtonWidget
......................................................................
testsuitegenerator: Test every triple of config options for ButtonWidget
Some time ago, before 506657626af3aad5c52ba5c7d198bfaddb4a6ba4, we
used to test every triple of config options for all widgets, but I
lowered it to every pair, as it was making the test suite huge. But
let's at least give ButtonWidget special attention, since some
features of the MediaWiki theme for it only kick in with three
specific config options.
This increases the size of JSPHP-suite.json from 185 K to 405 K.
Change-Id: I445df624303efb740730785adcbf0e8645ca4d16
---
M bin/testsuitegenerator.rb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/16/276216/1
diff --git a/bin/testsuitegenerator.rb b/bin/testsuitegenerator.rb
index 6cf16a4..e8ca838 100644
--- a/bin/testsuitegenerator.rb
+++ b/bin/testsuitegenerator.rb
@@ -113,7 +113,7 @@
required_config = klass[:methods][0][:params] || []
# generate every possible configuration of configuration option
sets
- maxlength = [config.length, 2].min
+ maxlength = [config.length, klass[:name] == 'ButtonWidget' ? 3
: 2].min
config_combinations = (0..maxlength).map{|l|
config.combination(l).to_a }.inject(:+)
# for each set, generate all possible values to use based on
option's type
config_combinations = config_combinations.map{|config_comb|
--
To view, visit https://gerrit.wikimedia.org/r/276216
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I445df624303efb740730785adcbf0e8645ca4d16
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
