Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/276464
Change subject: Protect against calling .classList on text nodes
......................................................................
Protect against calling .classList on text nodes
Change-Id: Ie6d1548a173bdd4dcb59f5e42d24bea9550583b4
---
M src/ce/ve.ce.Document.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/64/276464/1
diff --git a/src/ce/ve.ce.Document.js b/src/ce/ve.ce.Document.js
index 6b8c49c..334c539 100644
--- a/src/ce/ve.ce.Document.js
+++ b/src/ce/ve.ce.Document.js
@@ -231,12 +231,12 @@
if ( item.classList.contains( 've-ce-unicorn' ) ) {
if ( offset === startOffset ) {
// Return if empty unicorn pair at the
correct offset
- if ( item.previousSibling &&
item.previousSibling.classList.contains( 've-ce-unicorn' ) ) {
+ if ( item.previousSibling &&
item.previousSibling.classList && item.previousSibling.classList.contains(
've-ce-unicorn' ) ) {
return {
node: item.parentNode,
offset: current.offset
- 1
};
- } else if ( item.nextSibling &&
item.nextSibling.classList.contains( 've-ce-unicorn' ) ) {
+ } else if ( item.nextSibling &&
item.nextSibling.classList && item.nextSibling.classList.contains(
've-ce-unicorn' ) ) {
return {
node: item.parentNode,
offset: current.offset
+ 1
--
To view, visit https://gerrit.wikimedia.org/r/276464
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6d1548a173bdd4dcb59f5e42d24bea9550583b4
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
