Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/276478
Change subject: KeyDownHandlerFactory: Prevent duplication in handlerNamesByKeys
......................................................................
KeyDownHandlerFactory: Prevent duplication in handlerNamesByKeys
Change-Id: Ic6155e42d569cc115c7845e0c2971be2a041f77e
---
M src/ce/ve.ce.KeyDownHandlerFactory.js
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/78/276478/1
diff --git a/src/ce/ve.ce.KeyDownHandlerFactory.js
b/src/ce/ve.ce.KeyDownHandlerFactory.js
index fe0e786..ec6bfe4 100644
--- a/src/ce/ve.ce.KeyDownHandlerFactory.js
+++ b/src/ce/ve.ce.KeyDownHandlerFactory.js
@@ -37,9 +37,12 @@
keys = constructor.static.keys;
name = constructor.static.name;
+ // TODO: Clean up handlerNamesByKeys in unregister
for ( i = 0, ilen = keys.length; i < ilen; i++ ) {
this.handlerNamesByKeys[ keys[ i ] ] = this.handlerNamesByKeys[
keys[ i ] ] || [];
- this.handlerNamesByKeys[ keys[ i ] ].push( name );
+ if ( this.handlerNamesByKeys[ keys[ i ] ].indexOf( name ) ===
-1 ) {
+ this.handlerNamesByKeys[ keys[ i ] ].push( name );
+ }
}
};
--
To view, visit https://gerrit.wikimedia.org/r/276478
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6155e42d569cc115c7845e0c2971be2a041f77e
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
