jenkins-bot has submitted this change and it was merged.
Change subject: demo: Expand the dialog $overlay demo for testing scrolling
things off-screen
......................................................................
demo: Expand the dialog $overlay demo for testing scrolling things off-screen
Bug: T129521
Change-Id: I449810cbd3d7d1573f5c72e0cc6d8d19fca87f0b
---
M demos/pages/dialogs.js
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/demos/pages/dialogs.js b/demos/pages/dialogs.js
index 859e1d0..083b612 100644
--- a/demos/pages/dialogs.js
+++ b/demos/pages/dialogs.js
@@ -542,7 +542,7 @@
return 300;
};
DialogWithDropdowns.prototype.initialize = function () {
- var $spacer = $( '<div>' ).height( 150 );
+ var $spacer = $( '<div>' ).height( 350 );
DialogWithDropdowns.parent.prototype.initialize.apply( this,
arguments );
this.bookletLayout = new OO.ui.BookletLayout( {
outlined: true
@@ -627,6 +627,9 @@
} ), $spacer.clone() ]
} )
];
+ this.bookletLayout.on( 'set', function ( page ) {
+ page.$element[ 0 ].scrollTop = 300;
+ } );
this.bookletLayout.addPages( this.pages );
this.$body.append( this.bookletLayout.$element );
};
--
To view, visit https://gerrit.wikimedia.org/r/276528
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I449810cbd3d7d1573f5c72e0cc6d8d19fca87f0b
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
