jenkins-bot has submitted this change and it was merged.

Change subject: Remove fiscal number validation for PE and MX
......................................................................


Remove fiscal number validation for PE and MX

Bug: T129552
Change-Id: I4f92fa2cf8a4804f9f13e11d754946ea7e0d95c5
---
M gateway_common/DataValidator.php
M tests/DataValidatorTest.php
2 files changed, 1 insertion(+), 11 deletions(-)

Approvals:
  XenoRyet: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/gateway_common/DataValidator.php b/gateway_common/DataValidator.php
index f371287..70f7ed0 100644
--- a/gateway_common/DataValidator.php
+++ b/gateway_common/DataValidator.php
@@ -625,15 +625,6 @@
                                'min' => 8,
                                'max' => 9,
                        ),
-                       'MX' => array(
-                               'min' => 10,
-                               'max' => 18,
-                       ),
-                       'PE' => array(
-                               'numeric' => true,
-                               'min' => 8,
-                               'max' => 9,
-                       ),
                        'UY' => array(
                                'numeric' => true,
                                'min' => 6,
diff --git a/tests/DataValidatorTest.php b/tests/DataValidatorTest.php
index 10c870f..c106ac7 100644
--- a/tests/DataValidatorTest.php
+++ b/tests/DataValidatorTest.php
@@ -124,8 +124,7 @@
                        array( 'AR', 'ABC12312', false ),
                        array( 'AR', '12341234', true ),
                        array( 'AR', '1112223', false ),
-                       array( 'MX', 'ABC1234567', true ),
-                       array( 'MX', 'ZYX12345', false ),
+                       array( 'MX', '', true ), // Not required for MX
                );
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/276675
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4f92fa2cf8a4804f9f13e11d754946ea7e0d95c5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>
Gerrit-Reviewer: AndyRussG <andrew.green...@gmail.com>
Gerrit-Reviewer: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Ssmith <ssm...@wikimedia.org>
Gerrit-Reviewer: XenoRyet <dkozlow...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to