jenkins-bot has submitted this change and it was merged. Change subject: Reorganise the functions doing wfProfileOut and returning on all if branches. ......................................................................
Reorganise the functions doing wfProfileOut and returning on all if branches. Makes life easier for static analysis, since they don't need to handle if the end of a function where a wfProfileOut was not called was reachable or not. It is recommended to review this change ignoring whitespaces (specially for includes/parser/Tidy.php) Also documented the rationale for the elseif chain in UploadBase::detectVirus() Change-Id: Ic4f65937fa9e6f926d8fcfd670e3b0e99e06eefc --- M includes/Article.php M includes/EditPage.php M includes/Linker.php M includes/db/DatabaseMysql.php M includes/parser/Tidy.php M includes/upload/UploadBase.php 6 files changed, 45 insertions(+), 52 deletions(-) Approvals: Reedy: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/42940 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4f65937fa9e6f926d8fcfd670e3b0e99e06eefc Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Platonides <[email protected]> Gerrit-Reviewer: Platonides <[email protected]> Gerrit-Reviewer: Reedy <[email protected]> Gerrit-Reviewer: Umherirrender <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
