jenkins-bot has submitted this change and it was merged.
Change subject: Treat 'Type' values case-insensitively
......................................................................
Treat 'Type' values case-insensitively
We we crashing on a 'Balancetransfer' instead of 'BalanceTransfer'
Change-Id: I8260c020ab1598af19227836c37b74d98f4fdec3
---
M PaymentProviders/Adyen/Audit/AdyenAudit.php
1 file changed, 23 insertions(+), 23 deletions(-)
Approvals:
Cdentinger: Looks good to me, approved
jenkins-bot: Verified
diff --git a/PaymentProviders/Adyen/Audit/AdyenAudit.php
b/PaymentProviders/Adyen/Audit/AdyenAudit.php
index 42f9dda..e2b33f7 100644
--- a/PaymentProviders/Adyen/Audit/AdyenAudit.php
+++ b/PaymentProviders/Adyen/Audit/AdyenAudit.php
@@ -17,24 +17,24 @@
protected $ignoredStatuses;
protected $fileData = array();
protected static $ignoredTypes = array(
- 'Fee',
- 'MiscCosts',
- 'MerchantPayout',
- 'ChargebackReversed', // oh hey, we could try to handle these
- 'RefundedReversed',
- 'DepositCorrection',
- 'InvoiceDeduction',
- 'MatchedStatement',
- 'ManualCorrected',
- 'AuthorisationSchemeFee',
- 'BankInstructionReturned',
- 'InternalCompanyPayout',
- 'EpaPaid',
- 'BalanceTransfer',
- 'PaymentCost',
- 'SettleCost',
- 'PaidOut',
- 'PaidOutReversed',
+ 'fee',
+ 'misccosts',
+ 'merchantpayout',
+ 'chargebackreversed', // oh hey, we could try to handle these
+ 'refundedreversed',
+ 'depositcorrection',
+ 'invoicededuction',
+ 'matchedstatement',
+ 'manualcorrected',
+ 'authorisationschemefee',
+ 'bankinstructionreturned',
+ 'internalcompanypayout',
+ 'epapaid',
+ 'balancetransfer',
+ 'paymentcost',
+ 'settlecost',
+ 'paidout',
+ 'paidoutreversed',
);
public function __construct() {
@@ -97,7 +97,7 @@
protected function parseLine( $line ) {
$row = array_combine( $this->columnHeaders, $line );
- $type = $row['Type'];
+ $type = strtolower( $row['Type'] );
if ( in_array( $type, self::$ignoredTypes ) ) {
return;
}
@@ -111,11 +111,11 @@
$msg['contribution_tracking_id'] = $parts[0];
switch( $type ) {
- case 'Settled':
+ case 'settled':
$this->parseDonation( $row, $msg );
break;
- case 'Chargeback':
- case 'Refunded':
+ case 'chargeback':
+ case 'refunded':
$this->parseRefund( $row, $msg );
break;
default:
@@ -134,7 +134,7 @@
$msg['gateway_parent_id'] = $row['Psp Reference'];
$msg['gateway_refund_id'] = $row['Modification Reference'];
- if ( $row['Type'] === 'Chargeback' ) {
+ if ( strtolower( $row['Type'] ) === 'chargeback' ) {
$msg['type'] = 'chargeback';
} else {
$msg['type'] = 'refund';
--
To view, visit https://gerrit.wikimedia.org/r/276911
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8260c020ab1598af19227836c37b74d98f4fdec3
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Cdentinger <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
