Dzahn has uploaded a new change for review.
https://gerrit.wikimedia.org/r/276924
Change subject: shinken: "Puppet failure" is never OK
......................................................................
shinken: "Puppet failure" is never OK
Because of this service description, the messages
from shinken-wm keep looking like this:
< shinken-wm> RECOVERY - Puppet failure on tools-exec-1215 is OK: OK
A "Puppet failure" is never OK, the puppet run is either OK or CRIT.
It always made me look twice because of the word "failure" in there.
Change-Id: Ic0ffd1a396b5b459977b4e10e18fea961d7edede
---
M modules/shinken/files/labs/basic-instance-checks.cfg
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/24/276924/1
diff --git a/modules/shinken/files/labs/basic-instance-checks.cfg
b/modules/shinken/files/labs/basic-instance-checks.cfg
index 6018aed..545a021 100644
--- a/modules/shinken/files/labs/basic-instance-checks.cfg
+++ b/modules/shinken/files/labs/basic-instance-checks.cfg
@@ -15,7 +15,7 @@
define service {
check_command
check_graphite_threshold!http://labmon1001.eqiad.wmnet!10!$HOSTNOTES$.$HOSTNAME$.puppetagent.failed_events!0!0!10min!1!--over
hostgroup_name role::labs::instance
- service_description Puppet failure
+ service_description Puppet run
use generic-service
}
@@ -24,7 +24,7 @@
define servicedependency {
dependent_hostgroup_name role::labs::instance
host_name wikitech
- dependent_service_description Puppet failure
+ dependent_service_description Puppet run
service_description Wikitech web interface
execution_failure_criteria c
notification_failure_criteria c
@@ -34,7 +34,7 @@
define servicedependency {
dependent_hostgroup_name role::labs::instance
host_name labs-puppetmaster
- dependent_service_description Puppet failure
+ dependent_service_description Puppet run
service_description Labs Puppetmaster HTTPS
execution_failure_criteria c
notification_failure_criteria c
--
To view, visit https://gerrit.wikimedia.org/r/276924
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0ffd1a396b5b459977b4e10e18fea961d7edede
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
