jenkins-bot has submitted this change and it was merged.
Change subject: Remove not actually "@comment" from ResourceModules definition
......................................................................
Remove not actually "@comment" from ResourceModules definition
extension.json only removes top level and "config" keys that start with
@, so this "comment" was actually being passed onto ResourceLoader and
eventually being ignored at that stage.
But since it's not a recognized value, it causes validation of the
extension.json file against the schema to fail.
Bug: T128311
Change-Id: Ibed94e1818c8fc9c3afdc3e09d0af5e84c49a342
---
M extension.json
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Krinkle: Looks good to me, approved
Florianschmidtwelzow: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index c9c1387..cd3c5da 100644
--- a/extension.json
+++ b/extension.json
@@ -156,7 +156,6 @@
]
},
"ext.visualEditor.mwreference": {
- "@comment": "Deprecated alias",
"dependencies": [
"ext.cite.visualEditor"
]
--
To view, visit https://gerrit.wikimedia.org/r/273752
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibed94e1818c8fc9c3afdc3e09d0af5e84c49a342
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
