Florianschmidtwelzow has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/277044

Change subject: Limit mobile-specific editor stylings to mobile mode only
......................................................................

Limit mobile-specific editor stylings to mobile mode only

Currently, all adjustments for the editor, meant for mobile devices only,
are applied in both modes, desktop and mobile. Fix this by adding the modules
in mobile mode, only.

Bug: T129756
Change-Id: I4949720b002ed66748d98d6c351a9588dcaff4df
---
M includes/MobileFrontend.hooks.php
1 file changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/44/277044/1

diff --git a/includes/MobileFrontend.hooks.php 
b/includes/MobileFrontend.hooks.php
index 6ad0e77..c66cc34 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -848,14 +848,14 @@
 
                        // Allow modifications in mobile only mode
                        Hooks::run( 'BeforePageDisplayMobile', array( &$out, 
&$sk ) );
-               }
 
-               // add fallback editor styles to action=edit page
-               $requestAction = $out->getRequest()->getVal( 'action' );
-               if ( $noJsEditing && ( $requestAction === 'edit' || 
$requestAction === 'submit' ) ) {
-                       $out->addModuleStyles( array(
-                               'skins.minerva.fallbackeditor', 
'mobile.messageBox'
-                       ) );
+                       // add fallback editor styles to action=edit page
+                       $requestAction = $out->getRequest()->getVal( 'action' );
+                       if ( $noJsEditing && ( $requestAction === 'edit' || 
$requestAction === 'submit' ) ) {
+                               $out->addModuleStyles( array(
+                                       'skins.minerva.fallbackeditor', 
'mobile.messageBox'
+                               ) );
+                       }
                }
 
                return true;

-- 
To view, visit https://gerrit.wikimedia.org/r/277044
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4949720b002ed66748d98d6c351a9588dcaff4df
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to