Foxtrott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/277113
Change subject: Some cleanup
......................................................................
Some cleanup
Change-Id: Id412bd2c72429c9b2703f018f10796fa9fce2bc0
---
M src/BasicBackend.php
D src/Hooks.php
M src/Lingo.php
3 files changed, 2 insertions(+), 53 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Lingo
refs/changes/13/277113/1
diff --git a/src/BasicBackend.php b/src/BasicBackend.php
index 9ea5343..114a6da 100644
--- a/src/BasicBackend.php
+++ b/src/BasicBackend.php
@@ -30,7 +30,6 @@
use ApprovedRevs;
use ContentHandler;
use Hooks;
-use Page;
use Parser;
use ParserOptions;
use Revision;
@@ -45,12 +44,11 @@
*/
class BasicBackend extends Backend {
- protected $mArticleLines = array();
+ protected $mArticleLines = null;
/**
* Lingo\BasicBackend constructor.
* @param MessageLog|null $messages
- * @param LingoParser $lingoParser
*/
public function __construct( MessageLog &$messages = null ) {
@@ -188,7 +186,7 @@
private function setArticleLines() {
global $wgRequest;
- if ( $this->mArticleLines ) {
+ if ( $this->mArticleLines !== null ) {
return;
}
diff --git a/src/Hooks.php b/src/Hooks.php
deleted file mode 100644
index e00f846..0000000
--- a/src/Hooks.php
+++ /dev/null
@@ -1,43 +0,0 @@
-<?php
-
-/**
- * File holding the Lingo\Hooks class
- *
- * This file is part of the MediaWiki extension Lingo.
- *
- * @copyright 2011 - 2016, Stephan Gambke
- * @license GNU General Public License, version 2 (or any later version)
- *
- * The Lingo extension is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by the
Free
- * Software Foundation; either version 2 of the License, or (at your option)
any
- * later version.
- *
- * The Lingo extension is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
or
- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
more
- * details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program. If not, see <http://www.gnu.org/licenses/>.
- *
- * @author Stephan Gambke
- * @file
- * @ingroup Lingo
- */
-
-namespace Lingo;
-use MagicWord;
-use Parser;
-use PPFrame;
-
-/**
- * The Lingo\Hooks class.
- *
- * It contains the hook handlers of the extension
- *
- * @ingroup Lingo
- */
-class Hooks {
-}
-
diff --git a/src/Lingo.php b/src/Lingo.php
index acd4a06..e74db7c 100644
--- a/src/Lingo.php
+++ b/src/Lingo.php
@@ -77,12 +77,6 @@
}
}
-
-// $hookRegistry = new HookRegistry(
-// ApplicationFactory::getInstance()->getStore()
-// );
-//
-// $hookRegistry->register();
};
}
--
To view, visit https://gerrit.wikimedia.org/r/277113
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id412bd2c72429c9b2703f018f10796fa9fce2bc0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Lingo
Gerrit-Branch: master
Gerrit-Owner: Foxtrott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
