jenkins-bot has submitted this change and it was merged.
Change subject: Have mw.echo.api.APIHandler.markItemRead actually return a
promise
......................................................................
Have mw.echo.api.APIHandler.markItemRead actually return a promise
Per its docs which say it does.
Change-Id: I2a4fb393c1bc3eba31a1bad34342a11800767fb0
---
M modules/api/mw.echo.api.APIHandler.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mooeypoo: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/api/mw.echo.api.APIHandler.js
b/modules/api/mw.echo.api.APIHandler.js
index 5e7dd34..59fe1dd 100644
--- a/modules/api/mw.echo.api.APIHandler.js
+++ b/modules/api/mw.echo.api.APIHandler.js
@@ -122,7 +122,7 @@
* are marked as read.
*/
mw.echo.api.APIHandler.prototype.markItemRead = function ( itemId,
isRead ) {
- this.markItemsRead( [ itemId ], isRead );
+ return this.markItemsRead( [ itemId ], isRead );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/277426
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a4fb393c1bc3eba31a1bad34342a11800767fb0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
