jenkins-bot has submitted this change and it was merged.
Change subject: Avoid request overhead for legacy modules
......................................................................
Avoid request overhead for legacy modules
Follows-up 81093f6e4ef.
Mobile pages currently have an extra load.php request going out because at
run-time ResourceLoader discovers legacy modules aren't in any load queue
yet and has to create a lazy request for them.
This 4.9Kb (after gzip) request isn't great, but currently made either way.
Might as well let it happen with the main queue so that at least it's not an
extra request (and at that, a request that starts quite late and ends up
delaying other modules on mobile).
These two legacy modules will be removed from the default load soon (T111077)
at which point they won't be loaded unless individual modules express a need
for them (e.g. old gadgets may use that as stop-gap measure).
Change-Id: I9e6342bf71b7204c76db5bd066167a729596f908
---
M includes/skins/SkinMinerva.php
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 715c8f7..c1ae499 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -965,7 +965,6 @@
$modules = parent::getDefaultModules();
// flush unnecessary modules
$modules['content'] = array();
- $modules['legacy'] = array();
$modules['top'] = 'skins.minerva.scripts.top';
// Define all the modules that should load on the mobile site
and their dependencies.
--
To view, visit https://gerrit.wikimedia.org/r/277344
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e6342bf71b7204c76db5bd066167a729596f908
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
