jenkins-bot has submitted this change and it was merged.
Change subject: Dont submit invalid events
......................................................................
Dont submit invalid events
Throw away untracked events. This event (render-one) allows
for attaching tracking to particular results, it's not something
that should be logged on it's own.
Change-Id: I61469e3fd853dd17e91bb35d43fdafe65d1f1a50
---
M modules/ext.wikimediaEvents.search.js
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.wikimediaEvents.search.js
b/modules/ext.wikimediaEvents.search.js
index cfa5c36..6312920 100644
--- a/modules/ext.wikimediaEvents.search.js
+++ b/modules/ext.wikimediaEvents.search.js
@@ -43,6 +43,9 @@
loggingData.numberOfResults = data.numberOfResults;
} else if ( data.action === 'submit-form' ) {
loggingData.numberOfResults = data.numberOfResults;
+ } else if ( data.action === 'render-one' ) {
+ // untracked event
+ return;
}
loggingData.timeOffsetSinceStart = Math.round( this.timeStamp -
sessionStartTime ) ;
$.extend( loggingData, defaults );
--
To view, visit https://gerrit.wikimedia.org/r/277434
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61469e3fd853dd17e91bb35d43fdafe65d1f1a50
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
