Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/277570
Change subject: Pass class to the lazy loaded image
......................................................................
Pass class to the lazy loaded image
Bug: T129198
Change-Id: Id12505f5867ee2cf0def4572595aaa0afbe56b87
---
M includes/MobileFormatter.php
M resources/mobile.startup/Skin.js
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/70/277570/1
diff --git a/includes/MobileFormatter.php b/includes/MobileFormatter.php
index d6579de..8bce659 100644
--- a/includes/MobileFormatter.php
+++ b/includes/MobileFormatter.php
@@ -211,7 +211,7 @@
$imgPlaceholder = $doc->createElement( 'span' );
$imgPlaceholder->setAttribute( 'class',
'lazy-image-placeholder' );
$imgPlaceholder->setAttribute( 'style',
$dimensionsStyle );
- foreach ( [ 'src', 'alt', 'width', 'height', 'srcset' ]
as $attr ) {
+ foreach ( [ 'src', 'alt', 'width', 'height', 'srcset',
'class' ] as $attr ) {
if ( $img->hasAttribute( $attr ) ) {
$imgPlaceholder->setAttribute(
"data-$attr", $img->getAttribute( $attr ) );
}
diff --git a/resources/mobile.startup/Skin.js b/resources/mobile.startup/Skin.js
index f7771c3..78e4788 100644
--- a/resources/mobile.startup/Skin.js
+++ b/resources/mobile.startup/Skin.js
@@ -240,7 +240,7 @@
src: $placeholder.attr( 'data-src' ),
alt: $placeholder.attr( 'data-alt' ),
srcset: $placeholder.attr( 'data-srcset' )
- } );
+ } ).addClass( $placeholder.attr( 'data-class' ) );
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/277570
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id12505f5867ee2cf0def4572595aaa0afbe56b87
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
