Bene has uploaded a new change for review.
https://gerrit.wikimedia.org/r/277591
Change subject: Move mock factory method into base class
......................................................................
Move mock factory method into base class
This allows reuse of that method.
Needed for If2636e7
Change-Id: I9ccddea4d9e2f67914a5b74dc48f14f56a61da62
---
M repo/tests/phpunit/includes/Specials/SpecialSetLabelDescriptionAliasesTest.php
M repo/tests/phpunit/includes/Specials/SpecialWikibaseRepoPageTestBase.php
2 files changed, 18 insertions(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/91/277591/1
diff --git
a/repo/tests/phpunit/includes/Specials/SpecialSetLabelDescriptionAliasesTest.php
b/repo/tests/phpunit/includes/Specials/SpecialSetLabelDescriptionAliasesTest.php
index 35acc76..7ddc23d 100644
---
a/repo/tests/phpunit/includes/Specials/SpecialSetLabelDescriptionAliasesTest.php
+++
b/repo/tests/phpunit/includes/Specials/SpecialSetLabelDescriptionAliasesTest.php
@@ -64,25 +64,11 @@
$this->getEntityRevisionLookup(),
$this->getEntityStore(),
$this->getEntityPermissionChecker(),
- $this->getMockEditFitlerHookRunner()
+ $this->getEditFilterHookRunner()
)
);
return $page;
- }
-
- /**
- * @return EditFilterHookRunner
- */
- private function getMockEditFitlerHookRunner() {
- $runner = $this->getMockBuilder( EditFilterHookRunner::class )
- ->setMethods( array( 'run' ) )
- ->disableOriginalConstructor()
- ->getMock();
- $runner->expects( $this->any() )
- ->method( 'run' )
- ->will( $this->returnValue( Status::newGood() ) );
- return $runner;
}
/**
diff --git
a/repo/tests/phpunit/includes/Specials/SpecialWikibaseRepoPageTestBase.php
b/repo/tests/phpunit/includes/Specials/SpecialWikibaseRepoPageTestBase.php
index 7332509..957dac3 100644
--- a/repo/tests/phpunit/includes/Specials/SpecialWikibaseRepoPageTestBase.php
+++ b/repo/tests/phpunit/includes/Specials/SpecialWikibaseRepoPageTestBase.php
@@ -22,6 +22,7 @@
use Wikibase\Lib\Store\EntityRevisionLookup;
use Wikibase\Lib\Store\EntityStore;
use Wikibase\Lib\Store\EntityTitleLookup;
+use Wikibase\Repo\Hooks\EditFilterHookRunner;
use Wikibase\Repo\Store\EntityPermissionChecker;
use Wikibase\SummaryFormatter;
use Wikibase\Test\MockRepository;
@@ -108,6 +109,22 @@
}
/**
+ * @return EditFilterHookRunner
+ */
+ protected function getEditFilterHookRunner() {
+ $runner = $this->getMockBuilder( EditFilterHookRunner::class )
+ ->setMethods( array( 'run' ) )
+ ->disableOriginalConstructor()
+ ->getMock();
+
+ $runner->expects( $this->any() )
+ ->method( 'run' )
+ ->will( $this->returnValue( Status::newGood() ) );
+
+ return $runner;
+ }
+
+ /**
* @return SiteStore
*/
protected function getSiteStore() {
--
To view, visit https://gerrit.wikimedia.org/r/277591
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ccddea4d9e2f67914a5b74dc48f14f56a61da62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Bene <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
