Paladox has uploaded a new change for review.
https://gerrit.wikimedia.org/r/277614
Change subject: Revert "testsuitegenerator: Always test empty values for
'string' type, not just for 'label'"
......................................................................
Revert "testsuitegenerator: Always test empty values for 'string' type, not
just for 'label'"
This reverts commit df5cc372507ddf73a51263f14892a5f48a572fb6.
Bug: T130063
Change-Id: Ife4940b9f5c3528c058021052dc7cd952cc1ee58
---
M bin/testsuitegenerator.rb
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/14/277614/1
diff --git a/bin/testsuitegenerator.rb b/bin/testsuitegenerator.rb
index 26229e0..05c8cee 100644
--- a/bin/testsuitegenerator.rb
+++ b/bin/testsuitegenerator.rb
@@ -26,7 +26,7 @@
'null' => [nil],
'number' => [0, -1, 300],
'boolean' => [true, false],
- 'string' => ['Foo bar', '<b>HTML?</b>', '', ' '],
+ 'string' => ['Foo bar', '<b>HTML?</b>'],
}
# values to test for names
@@ -52,6 +52,7 @@
'icon' => ['image'],
'indicator' => ['down'],
'flags' => %w[constructive primary],
+ 'label' => expandos['string'] + ['', ' '],
# these are defined by Element and would bloat the tests
'classes' => true,
'id' => true,
--
To view, visit https://gerrit.wikimedia.org/r/277614
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife4940b9f5c3528c058021052dc7cd952cc1ee58
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
