jenkins-bot has submitted this change and it was merged.
Change subject: Add getFreeFormStopTransaction to GatewayType interface
......................................................................
Add getFreeFormStopTransaction to GatewayType interface
Another candidate for a helper class
Change-Id: I1b7453d9b6f408715d5caf9242512879dc414440
---
M gateway_common/GatewayType.php
M gateway_common/gateway.adapter.php
2 files changed, 9 insertions(+), 7 deletions(-)
Approvals:
Awight: Looks good to me, approved
jenkins-bot: Verified
diff --git a/gateway_common/GatewayType.php b/gateway_common/GatewayType.php
index 0a8679a..a4b3f4d 100644
--- a/gateway_common/GatewayType.php
+++ b/gateway_common/GatewayType.php
@@ -326,4 +326,13 @@
*/
public function getCurrentTransaction();
+ /**
+ * For making freeform stomp messages.
+ * As these are all non-critical, we don't need to be as strict as we
have been with the other stuff.
+ * But, we've got to have some standards.
+ * @param array $transaction The fields that we are interested in
sending.
+ * @return array The fields that will actually be sent. So,
$transaction ++ some other things we think we're likely to always need.
+ */
+ public function makeFreeformStompTransaction( $transaction );
+
}
diff --git a/gateway_common/gateway.adapter.php
b/gateway_common/gateway.adapter.php
index e57cc4f..b1f70a8 100644
--- a/gateway_common/gateway.adapter.php
+++ b/gateway_common/gateway.adapter.php
@@ -1614,13 +1614,6 @@
return $transaction;
}
- /**
- * For making freeform stomp messages.
- * As these are all non-critical, we don't need to be as strict as we
have been with the other stuff.
- * But, we've got to have some standards.
- * @param array $transaction The fields that we are interested in
sending.
- * @return array The fields that will actually be sent. So,
$transaction ++ some other things we think we're likely to always need.
- */
public function makeFreeformStompTransaction( $transaction ) {
if ( !array_key_exists( 'php-message-class', $transaction ) ) {
$this->logger->warning( "Trying to send a freeform
STOMP message with no class defined. Bad programmer." );
--
To view, visit https://gerrit.wikimedia.org/r/277685
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b7453d9b6f408715d5caf9242512879dc414440
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Cdentinger <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: XenoRyet <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
