Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/277728
Change subject: Fix error log spam from Special:ImportTranslations
......................................................................
Fix error log spam from Special:ImportTranslations
Each new translation would trigger a warning and shown as
changed translation instead of a new one.
Bug: T76014
Change-Id: If458cbcb8ddd7062fcc4beb273da8de06f91efba
---
M utils/MessageWebImporter.php
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/28/277728/1
diff --git a/utils/MessageWebImporter.php b/utils/MessageWebImporter.php
index 032b615..0e3143f 100644
--- a/utils/MessageWebImporter.php
+++ b/utils/MessageWebImporter.php
@@ -196,9 +196,10 @@
$changed = array();
foreach ( $messages as $key => $value ) {
- $fuzzy = $old = false;
+ $fuzzy = $old = null;
if ( isset( $collection[$key] ) ) {
+ // This returns null for if no existing
translation
$old = $collection[$key]->translation();
}
@@ -207,7 +208,7 @@
continue;
}
- if ( $old === false ) {
+ if ( $old === null ) {
$para = '<code class="mw-tmi-new">' .
htmlspecialchars( $key ) . '</code>';
$name = $context->msg(
'translate-manage-import-new' )->rawParams( $para )
->escaped();
--
To view, visit https://gerrit.wikimedia.org/r/277728
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If458cbcb8ddd7062fcc4beb273da8de06f91efba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
