Dzahn has submitted this change and it was merged. Change subject: puppet-lint: remove exception for nested classes ......................................................................
puppet-lint: remove exception for nested classes We only had a handful remaining nested classes and defines. And no, we don't like nesting them :) I fixed them all with one exception where i added lint::ignore around it. So now we can remove this global exception and let CI discourage people from adding any new ones. https://gerrit.wikimedia.org/r/#/c/278225/ https://gerrit.wikimedia.org/r/#/c/278230/ https://gerrit.wikimedia.org/r/#/c/278231/ https://gerrit.wikimedia.org/r/#/c/278229/ https://gerrit.wikimedia.org/r/#/c/278232/ https://gerrit.wikimedia.org/r/#/c/278233/ Bug:T93645 Change-Id: I5c8be1ddec64bf325e09b4755931067bcfc569e2 --- M .puppet-lint.rc 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: jenkins-bot: Verified Dzahn: Looks good to me, approved diff --git a/.puppet-lint.rc b/.puppet-lint.rc index 9bc0ff4..da238fc 100644 --- a/.puppet-lint.rc +++ b/.puppet-lint.rc @@ -2,9 +2,6 @@ # 2.8 will requires $::globalname. Skip for now. --no-variable_scope-check -# We really like nesting classes: ---no-nested_classes_or_defines-check - # Lot of long lines (ssh keys for example). --no-80chars-check -- To view, visit https://gerrit.wikimedia.org/r/278399 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c8be1ddec64bf325e09b4755931067bcfc569e2 Gerrit-PatchSet: 3 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Dzahn <[email protected]> Gerrit-Reviewer: Dzahn <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Ori.livneh <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
