Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/277999
Change subject: Narrow Deserializer interfaces in SnakSerializationRenderer
......................................................................
Narrow Deserializer interfaces in SnakSerializationRenderer
I get type warnings in my PHPStorm because the factory methods used to
feed these parameters return "Deserializer" objects. And indeed, this
implementation does not need anything from outside the interface.
Change-Id: Ie4bb5856432809d01e8ab9cb819fd581583c7966
---
M client/includes/DataAccess/Scribunto/SnakSerializationRenderer.php
1 file changed, 7 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/99/277999/1
diff --git a/client/includes/DataAccess/Scribunto/SnakSerializationRenderer.php
b/client/includes/DataAccess/Scribunto/SnakSerializationRenderer.php
index 64d5b43..21f141e 100644
--- a/client/includes/DataAccess/Scribunto/SnakSerializationRenderer.php
+++ b/client/includes/DataAccess/Scribunto/SnakSerializationRenderer.php
@@ -2,9 +2,8 @@
namespace Wikibase\Client\DataAccess\Scribunto;
+use Deserializers\Deserializer;
use Language;
-use Wikibase\DataModel\Deserializers\SnakDeserializer;
-use Wikibase\DataModel\Deserializers\SnakListDeserializer;
use Wikibase\DataModel\Snak\Snak;
use Wikibase\Lib\SnakFormatter;
@@ -24,7 +23,7 @@
private $snakFormatter;
/**
- * @var SnakDeserializer
+ * @var Deserializer
*/
private $snakDeserializer;
@@ -34,21 +33,21 @@
private $language;
/**
- * @var SnakListDeserializer
+ * @var Deserializer
*/
private $snakListDeserializer;
/**
* @param SnakFormatter $snakFormatter
- * @param SnakDeserializer $snakDeserializer
+ * @param Deserializer $snakDeserializer
* @param Language $language
- * @param SnakListDeserializer $snakListDeserializer
+ * @param Deserializer $snakListDeserializer
*/
public function __construct(
SnakFormatter $snakFormatter,
- SnakDeserializer $snakDeserializer,
+ Deserializer $snakDeserializer,
Language $language,
- SnakListDeserializer $snakListDeserializer
+ Deserializer $snakListDeserializer
) {
$this->snakFormatter = $snakFormatter;
$this->snakDeserializer = $snakDeserializer;
--
To view, visit https://gerrit.wikimedia.org/r/277999
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4bb5856432809d01e8ab9cb819fd581583c7966
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
