jenkins-bot has submitted this change and it was merged.
Change subject: Don't filter undos coming in via the "APIEditBeforeSave" hook
......................................................................
Don't filter undos coming in via the "APIEditBeforeSave" hook
For consistency with other hooks.
Bug: T126861
Change-Id: I087276495c6f5f7fb01855aee3798516869e1a3e
---
M AbuseFilter.hooks.php
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Daniel Kinzler: Looks good to me, approved
jenkins-bot: Verified
diff --git a/AbuseFilter.hooks.php b/AbuseFilter.hooks.php
index d00407a..859ad86 100755
--- a/AbuseFilter.hooks.php
+++ b/AbuseFilter.hooks.php
@@ -20,6 +20,12 @@
* @return bool
*/
public static function onAPIEditBeforeSave( $editPage, $text, &$result
) {
+ if ( $editPage->undidRev > 0 ) {
+ // This hook is also (unlike the non-API hooks) being
run on undo,
+ // but we don't want to filter in that case. T126861
+ return true;
+ }
+
$context = $editPage->mArticle->getContext();
$status = Status::newGood();
--
To view, visit https://gerrit.wikimedia.org/r/278071
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I087276495c6f5f7fb01855aee3798516869e1a3e
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Se4598 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
