Henning Snater has submitted this change and it was merged. Change subject: (bug 43304) Selecting a Snak type will show UI changes ......................................................................
(bug 43304) Selecting a Snak type will show UI changes Depends on DataValues change set I8609875e * When choosing a certain Snak type in the selector, the change will be reflected in the UI. This change set includes some refactoring to the jQuery.snakview which is now using a plain object structure rather than wb.Snak internally. This allows for better handling of states where not all aspects of the Snak are defined yet. Also, strict separation between changes on the data and representation by drawing the view has been achieved. * Includes refactoring of the snakview's variation strategies which do no have a value() function for setting/getting value and a draw() function without additional parameters. For information propagation to the variations, the new snakview.ViewState object has been introduced. * Removed some code and TODOs not valid anymore or from before we had variations (different Snak types). - patch set 3: Corrected spelling errors and updated message - patch set 4/5: Fixed bug when adding new Claim Change-Id: Ia479b2d56bcd45a2198f39616f444e6e8c3f49d7 --- M lib/resources/Resources.php M lib/resources/jquery.wikibase/jquery.wikibase.claimview.js A lib/resources/jquery.wikibase/jquery.wikibase.snakview.ViewState.js M lib/resources/jquery.wikibase/jquery.wikibase.snakview.js M lib/resources/jquery.wikibase/snakview.variations/snakview.variations.NoValue.js M lib/resources/jquery.wikibase/snakview.variations/snakview.variations.SomeValue.js M lib/resources/jquery.wikibase/snakview.variations/snakview.variations.Value.js M lib/resources/jquery.wikibase/snakview.variations/snakview.variations.Variation.js M lib/resources/wikibase.datamodel/wikibase.Snak.js M repo/Wikibase.i18n.php 10 files changed, 386 insertions(+), 201 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/43781 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia479b2d56bcd45a2198f39616f444e6e8c3f49d7 Gerrit-PatchSet: 6 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <[email protected]> Gerrit-Reviewer: Daniel Werner <[email protected]> Gerrit-Reviewer: Henning Snater <[email protected]> Gerrit-Reviewer: Tobias Gritschacher <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
