Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/278034
Change subject: Remove expand/collaps togglers from geo/time expert extenders
......................................................................
Remove expand/collaps togglers from geo/time expert extenders
This intentionally is a small step, so each patch is as small as possible
and always leaves the UI in a non-broken and non-broken looking state.
This does not remove the code. It's dead code now. Removing it would be
a breaking change, since others may have used it.
Bug: T109455
Bug: T109457
Change-Id: I3c62d98fa763d32a71df70d0e237f15796691960
---
M src/experts/GlobeCoordinateInput.js
M src/experts/TimeInput.js
M src/experts/resources.php
3 files changed, 0 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/data-values/value-view
refs/changes/34/278034/1
diff --git a/src/experts/GlobeCoordinateInput.js
b/src/experts/GlobeCoordinateInput.js
index ef171e0..2fcbcf1 100644
--- a/src/experts/GlobeCoordinateInput.js
+++ b/src/experts/GlobeCoordinateInput.js
@@ -124,10 +124,6 @@
this.$input,
[
this.preview,
- new vv.ExpertExtender.Toggler(
- this._messageProvider,
- $precisionContainer
- ),
new vv.ExpertExtender.Container(
$precisionContainer,
this.precisionRotator
diff --git a/src/experts/TimeInput.js b/src/experts/TimeInput.js
index 6b5f01d..de1bc19 100644
--- a/src/experts/TimeInput.js
+++ b/src/experts/TimeInput.js
@@ -104,10 +104,6 @@
self.calendarRotator.rotator.activate();
}
),
- new vv.ExpertExtender.Toggler(
- this._messageProvider,
- $precisionContainer.add(
$calendarContainer )
- ),
new vv.ExpertExtender.Container(
$precisionContainer,
this.precisionRotator
diff --git a/src/experts/resources.php b/src/experts/resources.php
index d1d8c2e..d2c2183 100644
--- a/src/experts/resources.php
+++ b/src/experts/resources.php
@@ -60,7 +60,6 @@
'jquery.valueview.ExpertExtender.Container',
'jquery.valueview.ExpertExtender.Listrotator',
'jquery.valueview.ExpertExtender.Preview',
- 'jquery.valueview.ExpertExtender.Toggler',
'jquery.valueview.experts',
'jquery.valueview.experts.StringValue',
'jquery.valueview.Expert',
@@ -138,7 +137,6 @@
'jquery.valueview.ExpertExtender.Container',
'jquery.valueview.ExpertExtender.Listrotator',
'jquery.valueview.ExpertExtender.Preview',
- 'jquery.valueview.ExpertExtender.Toggler',
'jquery.valueview.experts',
'jquery.valueview.Expert',
'util.MessageProvider',
--
To view, visit https://gerrit.wikimedia.org/r/278034
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c62d98fa763d32a71df70d0e237f15796691960
Gerrit-PatchSet: 1
Gerrit-Project: data-values/value-view
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
