Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/278289
Change subject: Remove local helplink implementation
......................................................................
Remove local helplink implementation
Since MediaWiki 1.25 the function addHelpLink exists in core.
This change removes compatibility for MediaWiki <= 1.24.
Change-Id: Ibbddf388e1cda183dd56472c325b7af9dc8a4a73
---
M Resources.php
M TranslateUtils.php
D resources/css/ext.translate.helplink.css
3 files changed, 1 insertion(+), 54 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/89/278289/1
diff --git a/Resources.php b/Resources.php
index 8fbbc4e..ab607df 100644
--- a/Resources.php
+++ b/Resources.php
@@ -135,11 +135,6 @@
),
) + $resourcePaths;
-$wgResourceModules['ext.translate.helplink'] = array(
- 'styles' => 'resources/css/ext.translate.helplink.css',
- 'position' => 'top',
-) + $resourcePaths;
-
$wgResourceModules['ext.translate.hooks'] = array(
'scripts' => 'resources/js/ext.translate.hooks.js',
'position' => 'top',
diff --git a/TranslateUtils.php b/TranslateUtils.php
index 8fcb741..fbc61e3 100644
--- a/TranslateUtils.php
+++ b/TranslateUtils.php
@@ -330,34 +330,7 @@
* @since 2012-01-12
*/
public static function addSpecialHelpLink( OutputPage $out, $to,
$overrideBaseUrl = false ) {
- if ( method_exists( $out, 'addHelpLink' ) ) {
- $out->addHelpLink( $to, $overrideBaseUrl );
-
- return;
- }
-
- // BC for MW <= 1.24
- $text = wfMessage( 'translate-gethelp' )->escaped();
-
- if ( $overrideBaseUrl ) {
- $helpUrl = $to;
- } else {
- $helpUrl =
"https://www.mediawiki.org/wiki/Special:MyLanguage/$to";;
- }
-
- $link = Html::rawElement(
- 'a',
- array(
- 'href' => $helpUrl,
- 'target' => '_blank',
- 'class' => 'mw-translate-helplink',
- ),
- $text
- );
-
- $out->addModuleStyles( 'ext.translate.helplink' );
- $wrapper = Html::rawElement( 'div', array( 'class' =>
'mw-translate-helplink-wrapper' ), $link );
- $out->addHTML( $wrapper );
+ $out->addHelpLink( $to, $overrideBaseUrl );
}
/**
diff --git a/resources/css/ext.translate.helplink.css
b/resources/css/ext.translate.helplink.css
deleted file mode 100644
index f8c3284..0000000
--- a/resources/css/ext.translate.helplink.css
+++ /dev/null
@@ -1,21 +0,0 @@
-/* BC for MW <= 1.24 */
-.mw-translate-helplink {
- background: url(../images/help.png) no-repeat scroll left center
transparent;
- /* @embed */
- background-image: -webkit-linear-gradient(transparent, transparent),
url('../images/help.svg');
- /* @embed */
- background-image: linear-gradient(transparent, transparent),
url('../images/help.svg');
- padding-left: 20px;
-}
-
-.mw-translate-helplink-wrapper {
- float: right;
- width: 100%;
- display: block;
- margin-top: -10px;
- margin-bottom: -10px;
-}
-
-.mw-translate-helplink-wrapper .mw-translate-helplink {
- float: right;
-}
--
To view, visit https://gerrit.wikimedia.org/r/278289
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbddf388e1cda183dd56472c325b7af9dc8a4a73
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
