Jonas Kress (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/277782
Change subject: Fix: Add qualifier does not disappear when a new statement is
saved
......................................................................
Fix: Add qualifier does not disappear when a new statement is saved
Bug: T128317
Change-Id: I669f81283318f8677708cd82fa52a08c5d31b3d3
---
M view/resources/jquery/wikibase/jquery.wikibase.statementview.js
1 file changed, 16 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/82/277782/1
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
index 8aa2292..08ad035 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
@@ -464,11 +464,18 @@
: wb.datamodel.Statement.RANK.NORMAL
);
this._createMainSnak();
- this._createQualifiersListview(
- this.options.value
- ? this.options.value.getClaim().getQualifiers()
- : new wb.datamodel.SnakList()
- );
+
+ if ( this.isInEditMode()
+ || this.options.value
+ &&
this.options.value.getClaim().getQualifiers().length
+ && !this.$qualifiers.children().length
+ ) {
+ this._createQualifiersListview(
+ this.options.value
+ ?
this.options.value.getClaim().getQualifiers()
+ : new wb.datamodel.SnakList()
+ );
+ }
this._createReferencesListview(
this.options.value ?
this.options.value.getReferences().toArray() : []
);
@@ -714,8 +721,10 @@
var qualifiers = this.options.value ?
this.options.value.getClaim().getQualifiers() : [];
- // Refill the qualifier listview with the initial (or new
initial) qualifiers:
- this._createQualifiersListview( qualifiers );
+ if ( qualifiers.length > 0 ) {
+ // Refill the qualifier listview with the initial (or
new initial) qualifiers:
+ this._createQualifiersListview( qualifiers );
+ }
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/277782
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I669f81283318f8677708cd82fa52a08c5d31b3d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
