Dzahn has submitted this change and it was merged.
Change subject: base/syslogs: fix "defined typed defined inside a class"
......................................................................
base/syslogs: fix "defined typed defined inside a class"
Change-Id: I1690f29f7d86a92cc2aecbfad17bf7b5db57c07a
---
M modules/base/manifests/syslogs.pp
A modules/base/manifests/syslogs/readable.pp
2 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
Gehel: Looks good to me, but someone else must approve
jenkins-bot: Verified
Dzahn: Looks good to me, approved
diff --git a/modules/base/manifests/syslogs.pp
b/modules/base/manifests/syslogs.pp
index 835868a..2d94349 100644
--- a/modules/base/manifests/syslogs.pp
+++ b/modules/base/manifests/syslogs.pp
@@ -4,14 +4,7 @@
$logfiles = [ 'syslog', 'messages' ],
) {
- define syslogs::readable() {
-
- file { "/var/log/${name}":
- mode => '0644',
- }
- }
-
if $readable == true {
syslogs::readable { $logfiles: }
}
-}
\ No newline at end of file
+}
diff --git a/modules/base/manifests/syslogs/readable.pp
b/modules/base/manifests/syslogs/readable.pp
new file mode 100644
index 0000000..b3eb19a
--- /dev/null
+++ b/modules/base/manifests/syslogs/readable.pp
@@ -0,0 +1,7 @@
+# are syslogs readable or not
+define base::syslogs::readable() {
+
+ file { "/var/log/${name}":
+ mode => '0644',
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/278232
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1690f29f7d86a92cc2aecbfad17bf7b5db57c07a
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: Gehel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
